cchung100m commented on code in PR #2600:
URL: https://github.com/apache/uniffle/pull/2600#discussion_r2347761474
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/reader/RssShuffleDataIterator.java:
##########
@@ -117,17 +117,20 @@ public boolean hasNext() {
// If ShuffleServer delete
ByteBuffer rawData = rawBlock != null ? rawBlock.getByteBuffer() : null;
- long fetchDuration = System.currentTimeMillis() - startFetch;
- shuffleReadMetrics.incFetchWaitTime(fetchDuration);
+ long readDuration = System.currentTimeMillis() - startFetch;
if (rawData != null) {
uncompress(rawBlock, rawData);
// create new iterator for shuffle data
long startSerialization = System.currentTimeMillis();
recordsIterator = createKVIterator(uncompressedData);
long serializationDuration = System.currentTimeMillis() -
startSerialization;
- readTime += fetchDuration;
+ long fetchDuration = System.currentTimeMillis() - startFetch;
+ shuffleReadMetrics.incFetchWaitTime(fetchDuration);
+ readTime += readDuration;
serializeTime += serializationDuration;
Review Comment:
Hi @zuston
Thanks and I updated the part you mentioned. Any suggestions would be
appreciated if you are available. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@uniffle.apache.org
For additional commands, e-mail: issues-h...@uniffle.apache.org
