yl09099 commented on code in PR #2632:
URL: https://github.com/apache/uniffle/pull/2632#discussion_r2378823512
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -908,9 +908,9 @@ public void removeResources(String appId, boolean
checkAppExpired) {
ShuffleBlockIdManager manager =
shuffleTaskInfo.getShuffleBlockIdManager();
if (manager != null) {
- manager.removeBlockIdByAppId(appId);
+ manager.remove(appId);
}
- shuffleBlockIdManager.removeBlockIdByAppId(appId);
+ shuffleBlockIdManager.remove(appId);
Review Comment:
> Got it. Let's fix this here
It seems that it cannot be deleted here. The parameters passed from the
client have created two different objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
