zuston commented on code in PR #2638:
URL: https://github.com/apache/uniffle/pull/2638#discussion_r2419039914
##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -573,6 +573,9 @@ public RssSendShuffleDataResponse
sendShuffleData(RssSendShuffleDataRequest requ
List<ShuffleBlock> shuffleBlocks = Lists.newArrayList();
int partitionRequireSize = 0;
for (ShuffleBlockInfo sbi : ptb.getValue()) {
+ if (sbi.getData().refCnt() == 0) {
Review Comment:
This may not safe, I think the fast fail will be better than slient sucess.
But for this case, I haven't found the root cause about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
