jerqi commented on PR #2651: URL: https://github.com/apache/uniffle/pull/2651#issuecomment-3435865125
> > > > Is it ok if the data is big? > > > > > > > > > Normally it wont happen that the block size is controlled by the writer that the block will be flushed when reaching the threshold. > > > > > > One record may be large. For example, I ever saw 100MB record. > > Maybe the default threshold value could be more larger. I hope this PR could make task fail as fast as possible rather than hang that will be terrible Just give u some input. Should the timeout consider the data length? If u think it is ok to keep current state, I'm ok, too. Because this is the corner cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
