xianjingfeng commented on code in PR #2676:
URL: https://github.com/apache/uniffle/pull/2676#discussion_r2526844093
##########
server/src/main/java/org/apache/uniffle/server/block/PartitionedShuffleBlockIdManager.java:
##########
@@ -110,6 +110,11 @@ public byte[] getFinishedBlockIds(
Map<Integer, Roaring64NavigableMap> partitionToBlockId =
shuffleIdToPartitions.get(shuffleId);
+ if (partitionToBlockId == null) {
+ LOG.warn("Empty blockIds for app: {}, shuffleId: {}. This should not
happen", appId, shuffleId);
Review Comment:
it is normal that partitionToBlockId is null. Because the partition may not
contain any data.
##########
server/src/main/java/org/apache/uniffle/server/block/PartitionedShuffleBlockIdManager.java:
##########
@@ -110,6 +110,11 @@ public byte[] getFinishedBlockIds(
Map<Integer, Roaring64NavigableMap> partitionToBlockId =
shuffleIdToPartitions.get(shuffleId);
+ if (partitionToBlockId == null) {
+ LOG.warn("Empty blockIds for app: {}, shuffleId: {}. This should not
happen", appId, shuffleId);
+ return null;
Review Comment:
An empty Roaring64NavigableMap should be return here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
