zuston commented on code in PR #2690:
URL: https://github.com/apache/uniffle/pull/2690#discussion_r2575456919
##########
server/src/main/java/org/apache/uniffle/server/block/PartitionedShuffleBlockIdManager.java:
##########
@@ -110,6 +110,10 @@ public byte[] getFinishedBlockIds(
Map<Integer, Roaring64NavigableMap> partitionToBlockId =
shuffleIdToPartitions.get(shuffleId);
+ if (partitionToBlockId == null) {
+ return RssUtils.serializeBitMap(Roaring64NavigableMap.bitmapOf());
Review Comment:
Maybe fast fail is better ? cc @xianjingfeng
##########
server/src/main/java/org/apache/uniffle/server/block/PartitionedShuffleBlockIdManager.java:
##########
@@ -118,7 +122,15 @@ public byte[] getFinishedBlockIds(
lockForBitmap.readLock().lock();
try {
Roaring64NavigableMap bitmap = partitionToBlockId.get(partitionId);
- res.or(bitmap);
+ if (bitmap != null) {
+ res.or(bitmap);
+ } else {
+ LOG.warn(
Review Comment:
log and then fast fail if this should not happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
