xianjingfeng commented on code in PR #2702:
URL: https://github.com/apache/uniffle/pull/2702#discussion_r2642428179
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -290,6 +290,10 @@ public StatusCode cacheShuffleData(
}
if (!isPreAllocated) {
updateUsedMemory(size);
+ } else {
Review Comment:
@jerqi See the code below, if `addBlock(block) == false`, the duplicate
block will be released. However, the `encodedLength` of the buffer will not
include the `encodedLength` of the duplicate block. And the `encodedLength` of
the buffer is the memory size to be released where the buffer flush. And
duplicated block is a known problem. #926
https://github.com/apache/uniffle/blob/a2c2d056ce8fd49af025eaa48785b94d21515557/server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithLinkedList.java#L61-L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
