jerqi commented on code in PR #2708:
URL: https://github.com/apache/uniffle/pull/2708#discussion_r2681964492
##########
server/src/main/java/org/apache/uniffle/server/TopNShuffleDataSizeOfAppCalcTask.java:
##########
@@ -127,8 +135,8 @@ public List<Map.Entry<String, ShuffleTaskInfo>>
calcTopNOnHadoopDataSizeTaskInfo
public void start() {
LOG.info("TopNShuffleDataSizeOfAppCalcTask start schedule.");
- this.scheduler.scheduleAtFixedRate(
- this::calcTopNShuffleDataSize,
+ this.scheduler.scheduleWithFixedDelay(
+ this::calcTopNShuffleDataSizeIgnoreErrors,
Review Comment:
ExceptionHandler may be better. You can see
https://stackoverflow.com/questions/3875739/exception-handling-in-threadpools/3875784#3875784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
