wForget commented on code in PR #2710:
URL: https://github.com/apache/uniffle/pull/2710#discussion_r2684718902
##########
client-spark/extension/src/main/scala/org/apache/spark/UniffleStatusStore.scala:
##########
@@ -196,13 +235,11 @@ case class ReassignInfoUIData(event:
TaskReassignInfoEvent) {
def id: String = classOf[ReassignInfoUIData].getName()
}
-sealed abstract class ShuffleType private ()
-object ShuffleType {
- val READ: ShuffleType = new ShuffleType {}
- val WRITE: ShuffleType = new ShuffleType {}
+object ShuffleType extends Enumeration {
+ val READ, WRITE = Value
Review Comment:
Scala Enumeration fails spotbug checks. Can I change it to a String type?
```
[INFO] Total bugs: 2
Error: Medium: The method name org.apache.spark.ShuffleType.ValueOrdering()
doesn't start with a lower case letter [org.apache.spark.ShuffleType] In
UniffleStatusStore.scala NM_METHOD_NAMING_CONVENTION
Error: Medium: The method name org.apache.spark.ShuffleType.ValueSet()
doesn't start with a lower case letter [org.apache.spark.ShuffleType] In
UniffleStatusStore.scala NM_METHOD_NAMING_CONVENTION
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
