zuston commented on code in PR #2729:
URL: https://github.com/apache/uniffle/pull/2729#discussion_r2796675805
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/DataPusher.java:
##########
@@ -124,27 +124,26 @@ public CompletableFuture<Long> send(AddBlockEvent event) {
String taskId = event.getTaskId();
List<ShuffleBlockInfo> blocks = event.getShuffleDataInfoList();
List<ShuffleBlockInfo> validBlocks =
filterOutStaleAssignmentBlocks(taskId, blocks);
- if (CollectionUtils.isEmpty(validBlocks)) {
- return 0L;
- }
SendShuffleDataResult result = null;
try {
- result =
- shuffleWriteClient.sendShuffleData(
- rssAppId,
- event.getStageAttemptNumber(),
- validBlocks,
- () -> !isValidTask(taskId));
- // completionCallback should be executed before updating
taskToSuccessBlockIds
- // structure to avoid side effect
- Set<Long> succeedBlockIds = getSucceedBlockIds(result);
- for (ShuffleBlockInfo block : validBlocks) {
-
block.executeCompletionCallback(succeedBlockIds.contains(block.getBlockId()));
+ if (CollectionUtils.isNotEmpty(validBlocks)) {
+ result =
+ shuffleWriteClient.sendShuffleData(
+ rssAppId,
+ event.getStageAttemptNumber(),
+ validBlocks,
+ () -> !isValidTask(taskId));
+ // completionCallback should be executed before updating
taskToSuccessBlockIds
+ // structure to avoid side effect
Review Comment:
original logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
