zuston commented on code in PR #2731:
URL: https://github.com/apache/uniffle/pull/2731#discussion_r2866881294
##########
common/src/main/java/org/apache/uniffle/common/netty/buffer/MultiFileSegmentManagedBuffer.java:
##########
@@ -24,10 +24,11 @@
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import io.netty.channel.FileRegion;
-import io.netty.util.CompositeFileRegion;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.uniffle.common.netty.protocol.CompositeFileRegion;
Review Comment:
It looks we already have the customized CompositeFileRegion , so we should
reuse this? What's the difference with the netty based
##########
common/src/main/java/org/apache/uniffle/common/netty/protocol/CompositeFileRegion.java:
##########
@@ -114,13 +112,7 @@ public boolean release(int decrement) {
}
@Override
- protected void deallocate() {
- for (FileRegion region : regions) {
- if (region instanceof AbstractReferenceCounted) {
- ((AbstractReferenceCounted) region).deallocate();
- }
- }
- }
+ protected void deallocate() {}
Review Comment:
What's the difference with the `deallocate` and `release` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
