roryqi commented on code in PR #2735:
URL: https://github.com/apache/uniffle/pull/2735#discussion_r2867117130
##########
client/src/main/java/org/apache/uniffle/client/impl/DecompressionWorker.java:
##########
@@ -132,6 +163,7 @@ public DecompressedShuffleBlock get(int batchIndex, int
segmentIndex) {
// block
if (block != null) {
nowMemoryUsed.addAndGet(-block.getUncompressLength());
+ segmentPermits.ifPresent(x -> x.release());
Review Comment:
When block is null, we don't release. Will it cause dead lock? Should we use
try finally to gurantee the release of the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
