[
https://issues.apache.org/jira/browse/YUNIKORN-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076412#comment-17076412
]
Kinga Marton commented on YUNIKORN-68:
--------------------------------------
My first plan was to modify [admission_controller.go mutate
method|https://github.com/apache/incubator-yunikorn-k8shim/blob/master/pkg/plugin/admissioncontrollers/webhook/admission_controller.go#L95]
with checking if schedulerName was explicitly set and update the schedulerName
and the labels only if schedulerName was left empty. But, at that point, the
schedulerName is already filled with {{default-scheduler}} value in case it was
left empty, so my plan will not work.
I am thinking of adding a label to the pod and skip the schedulerName update
based on that label. I don't consider this solution an elegant one, so any
other idea is very welcomed.
[~wwei] what do you think? Do you have any better ideas than using a label?
> YuniKorn admission-controller should skip pods that explicitly set
> schedulerName
> --------------------------------------------------------------------------------
>
> Key: YUNIKORN-68
> URL: https://issues.apache.org/jira/browse/YUNIKORN-68
> Project: Apache YuniKorn
> Issue Type: Bug
> Reporter: Kinga Marton
> Assignee: Kinga Marton
> Priority: Major
>
> Currently, as long as the admission-controller is enabled, it will mutate the
> pod's spec and set schedulerName to Yunikorn no matter what. But in case some
> user wants to leverage default scheduler, and they set schedulerName
> explicitly, we should let it be that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
