[ 
https://issues.apache.org/jira/browse/YUNIKORN-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076807#comment-17076807
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-72:
-----------------------------------------------

The data race is logged because we update the configuration pointer we store. 
This is a test only issue. The pointer is created in {{init}} and we update it 
in {{Set}}. We should change {{Set}} into an update call and replace the values 
that need to be replaced in the original created configuration.

We should treat the pointer to the config as a non changing value. Passing the 
struct around by value (not a pointer) is not an option as the struct is large. 

> data race in unit test: TestTaskStateTransitions
> ------------------------------------------------
>
>                 Key: YUNIKORN-72
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-72
>             Project: Apache YuniKorn
>          Issue Type: Test
>          Components: test - unit
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Weiwei Yang
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: yunikorn-67_test_fail.txt
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Once in a while the TestTaskStateTransitions test fails in the shim with a 
> data race.
> The test is flaky and needs to be fixed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to