[
https://issues.apache.org/jira/browse/YUNIKORN-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098656#comment-17098656
]
Sunil G commented on YUNIKORN-112:
----------------------------------
Lot of .yml files are missing an ASF header
{code:java}
./k8shim/deployments/scheduler/prometheus.yml
./web/docker-compose.yml
./k8shim/landmark/docker_images.yaml
./k8shim/conf/queues.yaml
./k8shim/deployments/scheduler/yunikorn-rbac.yaml
./k8shim/deployments/scheduler/scheduler.yaml
./k8shim/deployments/scheduler/scheduler-load.yaml
./k8shim/deployments/examples/predicates/pod-anti-affinity-example.yaml
./k8shim/deployments/examples/predicates/node-affinity-example.yaml
./k8shim/deployments/examples/predicates/pod-anti-affinity-p1.yaml
./k8shim/deployments/examples/predicates/pod-anti-affinity-p0.yaml
./k8shim/deployments/examples/predicates/pod-affinity-example.yaml
./k8shim/deployments/examples/predicates/pod-nodeselector-example.yaml
./k8shim/deployments/examples/spark30/executor.yaml
./k8shim/deployments/examples/spark30/driver.yaml
./k8shim/deployments/examples/admission-controller-tests/nginx.yaml
./k8shim/deployments/examples/admission-controller-tests/nginx-yk.yaml
./k8shim/deployments/examples/sleep/batch-sleep-job.yaml
./k8shim/deployments/examples/sleep/sleeppods.yaml
./k8shim/deployments/examples/namespace/queues.yaml
./k8shim/deployments/examples/namespace/namespaces.yaml
./k8shim/deployments/examples/namespace/sleeppod_dev.yaml
./k8shim/deployments/examples/namespace/sleeppod_prod.yaml
./k8shim/deployments/examples/nginx/nginx.yaml
./k8shim/deployments/examples/volume/pod-ebs-exist.yaml
./k8shim/deployments/examples/volume/ebs-pv.yaml
./k8shim/deployments/examples/volume/nfs-server.yaml
./k8shim/deployments/examples/volume/pod-ebs-dynamic.yaml
./k8shim/deployments/examples/volume/pod-nfs.yaml
./k8shim/deployments/examples/volume/storage-class.yaml
./k8shim/deployments/examples/volume/pod-local.yaml
./k8shim/deployments/examples/volume/pod-ebs-direct.yaml
./k8shim/deployments/examples/volume/local-pv.yaml
./k8shim/helm-charts/yunikorn/Chart.yaml
./k8shim/helm-charts/yunikorn/templates/deployment.yaml
./k8shim/helm-charts/yunikorn/templates/service.yaml
./k8shim/helm-charts/yunikorn/templates/rbac.yaml
./k8shim/helm-charts/yunikorn/templates/configmap.yaml
./k8shim/helm-charts/yunikorn/values.yaml
./core/config/queues.yaml
./core/config/limit.yaml {code}
> Fix ASF release issues
> ----------------------
>
> Key: YUNIKORN-112
> URL: https://issues.apache.org/jira/browse/YUNIKORN-112
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: release
> Reporter: Weiwei Yang
> Priority: Blocker
>
> Felix gives us some feedback on our first release, we should make sure they
> are fixed in the next release, items include:
> - incubating in name
> - signature and hash fine
> - DISCLAIMER is ok - as above
> - LICENSE and NOTICE are fine
> - Ok with binary files - see note below
> - See note below on ASF headers
> - didn't compile from source
> 1. SHOULD: instead of a personal directory, release SHOULD be staged on
> [https://dist.apache.org/repos/dist/dev/incubator/yunikorn].
> [https://incubator.apache.org/guides/releasemanagement.html#podling_constraints]
> this include the signing KEYS file that should be kept as a project KEYS file
> instead of a personal one/location
> 2. it is a bit strange that you have 5 LICENSE files, you can exclude the one
> in subdirectories when you build the source tarball?
> 3. might want to check the license for the image files: png, jpg - where are
> they from?
> 4. SHOULD: a large number of files should also have ASF headers, eg. .mod,
> .yaml, .md, .go
> 5. nice to have: more details on go setup for dev environment (maybe just a
> quick link), go setup info without GoLand IDE. It could be helpful to know
> more on how to build (is this the build step?
> [https://github.com/apache/incubator-yunikorn-core/blob/master/docs/developer-guide.md#core-component-build])
> 6. SHOULD: put Apache Incubator logo on the
> websitehttps://[incubator.apache.org/guides/press-kit.html|http://incubator.apache.org/guides/press-kit.html]
> [http://yunikorn.apache.org/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
