[
https://issues.apache.org/jira/browse/YUNIKORN-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-53.
-------------------------------------------
Fix Version/s: 0.9
Resolution: Fixed
Both repos have now been merged, thank you for the contribution [~adam.antal]
> Use asserts for nil error checks in test code
> ---------------------------------------------
>
> Key: YUNIKORN-53
> URL: https://issues.apache.org/jira/browse/YUNIKORN-53
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: test - smoke, test - unit
> Reporter: Wilfred Spiegelenburg
> Assignee: Adam Antal
> Priority: Minor
> Labels: newbie, pull-request-available
> Fix For: 0.9
>
>
> In a lot of tests we use the construct:
> {code}
> if err != nil {
> t.Fatal("some text"
> }{code}
> We should replace that with the simple:
> {code}
> assert.NilError(t, err, "some text"){code}
> that is part of the standard assert package we already use in the test code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
