[
https://issues.apache.org/jira/browse/YUNIKORN-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105976#comment-17105976
]
Wilfred Spiegelenburg commented on YUNIKORN-139:
------------------------------------------------
The problem is here:
{code:java}
16-rwxr-xr-x 1 runner docker 21794816 May 13 03:37 golangci-lint
17running golangci-lint
18fatal: Needed a single revision
{code}
The make file lint target runs:
{code}
headSHA=$$(git rev-parse --short=12 origin/HEAD) ; \
$${lintBin} run --new-from-rev=$${headSHA}
{code}
The {{git rev}} gives back multiple revisions: it looks like we do not have an
origin set as the remote.
But the git checkout shows that there is an origin added:
{code}
Initialized empty Git repository in
/home/runner/work/incubator-yunikorn-core/incubator-yunikorn-core/.git/
/usr/bin/git remote add origin
https://github.com/apache/incubator-yunikorn-core
{code}
We can also not rely on HEAD as in the PR the HEAD is moved to the last commit
in the PR and the lint check does not work as nothing is _new_
> [core] Fix lint checks
> ----------------------
>
> Key: YUNIKORN-139
> URL: https://issues.apache.org/jira/browse/YUNIKORN-139
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Kinga Marton
> Priority: Major
>
> Lint checks are showing a lot of issues, even in those files what are not
> touched by a PR. This will cause to skip the unit tests as wellÂ
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
