[
https://issues.apache.org/jira/browse/YUNIKORN-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108658#comment-17108658
]
Weiwei Yang commented on YUNIKORN-153:
--------------------------------------
Thanks [~wilfreds] for creating this, this makes sense.
I suggest moving these functions to a separate file in the common package, e.g
\{{si_helper.go}} and tests to \{{si_helper_test.go}}.
> Move updateRequest creation out of resource.go
> ----------------------------------------------
>
> Key: YUNIKORN-153
> URL: https://issues.apache.org/jira/browse/YUNIKORN-153
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Ting Yao,Huang
> Priority: Major
> Labels: newbie
>
> In the resource.go file we have a number of functions that are used to create
> {{si.UpdateRequest}}.
> these functions do not belong in the resource code and should be moved to a
> separate file with the test that belong to it also moved out of the
> resource_test.go file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
