Wilfred Spiegelenburg commented on YUNIKORN-158:

The change that is committed via PR #117 does not work and I have reverted the 

When I build the admission controller image the docker part complains with the 
following message:
 ---> 557c8e8053ed
[Warning] One or more build-args [DOCKER_IMAGE_REGISTRY DOCKER_IMAGE_VERSION] 
were not consumed
Successfully built 557c8e8053ed {code}
The build finishes but this is not what it is supposed to do.

When I build the scheduler image it is still pointing to the wrong admission 

The change for the template should be in the scheduler image and use the same 
procedure with {{sed}} from the makefile instead of making the change via the 
docker file

> Admission controller deployment file should use the same version as the 
> scheduler
> ---------------------------------------------------------------------------------
>                 Key: YUNIKORN-158
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-158
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: shim - kubernetes
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>            Priority: Major
>              Labels: pull-request-available
> Today, the admission controller is deployed as a post-start hook in the 
> scheduler pod, and the template file has hard coded docker image name, 
> [https://github.com/apache/incubator-yunikorn-k8shim/blob/b8a4a01fa1f6149c8617c914a721296a71037736/deployments/admission-controllers/scheduler/templates/server.yaml.template#L33.]
>  We should get this fixed and make sure the admission controller version is 
> always aligned with the scheduler. 

This message was sent by Atlassian Jira

To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to