[ 
https://issues.apache.org/jira/browse/YUNIKORN-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121074#comment-17121074
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-174:
------------------------------------------------

[~wwei] we need to get this PR in for the interface before we release 0.9
Just to make sure we do not forget this.

> Fix SI constant change from YUNIKORN-135
> ----------------------------------------
>
>                 Key: YUNIKORN-174
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-174
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: scheduler-interface
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Blocker
>              Labels: pull-request-available
>
> The build of the SI does not clean up correctly and leaves a file behind even 
> if there are no changes (typo in Makefile)
> Multiple k8shim only constants are part of the spec which should not be in 
> the SI. They are not shared between the k8shim and other shims or the core:
>  * SparkLabelAppID
>  * SparkLabelRole
>  * SparkLabelRoleDriver
>  * LabelApp
>  * LabelApplicationID
>  * LabelQueueName
> And we have no default resource types in the product. The core does not use 
> them in the production code. They are only used in tests and we should remove 
> them from tests also to highlight the fact that the core is resource type 
> agnostic:
>  * memory
>  * vcore



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to