[
https://issues.apache.org/jira/browse/YUNIKORN-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148287#comment-17148287
]
Wilfred Spiegelenburg commented on YUNIKORN-255:
------------------------------------------------
PR #180 covers all the points above if I am correct.
With the change to remove the returned error from the SendEvent call at least
one of the points above is not valid anymore.
Thank you [~adam.antal] committed to trunk
> Cleanup code from event cache change
> ------------------------------------
>
> Key: YUNIKORN-255
> URL: https://issues.apache.org/jira/browse/YUNIKORN-255
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: Adam Antal
> Priority: Major
> Labels: pull-request-available
>
> There are a number of places where the code for the event cache needs a
> cleanup:
> - need comments throughout the code explaining assumptions made and behaviour
> - add negative tests where they are missing
> Code comments:
> - entrypoint.go clean up if structure around lines 85-90
> - rationalise event_cache startup around channel creation, service start and
> store cleanup on shutdown
> - event_cache_test: document what the tests do, use loops to generate events,
> make sure test names cover what is being tested.
> - event_publisher: remove isStopped and use atomic directly, data loss on
> send failure, error from SendEvent is a non nil value no need to check for ""
> - event_publisher_test: mockEventPlugin is a failing plugin and should be
> reusable
> - event_store: optimise collectevents by using a 3 param make call for array
> - event_store_test: document what the tests do, use loops to generate events,
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
