[
https://issues.apache.org/jira/browse/YUNIKORN-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159003#comment-17159003
]
Kinga Marton commented on YUNIKORN-286:
---------------------------------------
While working on YUNNIKORN-269 I was wondering why are we embedding the
admission controller in the scheduler? Wouldn't be better to handle it
separately and include it in the Helm chart, like this:
[https://github.com/volcano-sh/volcano/blob/master/installer/helm/chart/volcano/templates/admission.yaml
?|https://github.com/volcano-sh/volcano/blob/master/installer/helm/chart/volcano/templates/admission.yaml]
> Make admission-controller image repo/version/pullPolicy configurable via
> helm-charts
> ------------------------------------------------------------------------------------
>
> Key: YUNIKORN-286
> URL: https://issues.apache.org/jira/browse/YUNIKORN-286
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Major
> Labels: pull-request-available
>
> Currently, the admission controller image repo/version/pullPolicy are
> generated during {{make image}}. That means they cannot be modified from
> outside. We need to make these field configurable from helm-charts install.
> Note, once this change is made, we will need a subsequential task to update
> the helm-chart in the helm-hub for the latest images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
