[
https://issues.apache.org/jira/browse/YUNIKORN-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang updated YUNIKORN-311:
---------------------------------
Description:
Code coverage is a important phase in CI/CD, but we are missing the report now.
Not sure when and how this happens, but in the past, we were able to see the
report published to each PR.
https://github.com/apache/incubator-yunikorn-core/blob/d2a76c0d7000bb50e377f170538938236c1144c5/Makefile#L81
this is supposed to generate the coverage txt, and this
https://github.com/apache/incubator-yunikorn-core/blob/d2a76c0d7000bb50e377f170538938236c1144c5/.travis.yml#L42
is supposed to do the reporting.
was:
After the PR for the e2e tests the code coverage using codecov is no longer
updating the PRs with the results. This has started happening after the
changes from PR #130 from YUNIKORN-163
The change is purely this line in the make file:
* new run: {{go test ./pkg/... -cover -race …}}
* old run: {{go test ./... -race}}
when you run the old run with the ci tests included it fails with a panic.
We need to fix the coverage and or the panic
> Code coverage is not updating for the core builds
> --------------------------------------------------
>
> Key: YUNIKORN-311
> URL: https://issues.apache.org/jira/browse/YUNIKORN-311
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: build, shim - kubernetes
> Affects Versions: 0.9
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
>
> Code coverage is a important phase in CI/CD, but we are missing the report
> now.
> Not sure when and how this happens, but in the past, we were able to see the
> report published to each PR.
> https://github.com/apache/incubator-yunikorn-core/blob/d2a76c0d7000bb50e377f170538938236c1144c5/Makefile#L81
> this is supposed to generate the coverage txt, and this
> https://github.com/apache/incubator-yunikorn-core/blob/d2a76c0d7000bb50e377f170538938236c1144c5/.travis.yml#L42
> is supposed to do the reporting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
