[ 
https://issues.apache.org/jira/browse/YUNIKORN-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190539#comment-17190539
 ] 

Weiwei Yang commented on YUNIKORN-397:
--------------------------------------

Hi [~wilfreds]

Does go.mod file have to define the golang version?
I am not sure if that was added by the IDE or that's something must be set.

> Makefile should use go version from go.mod
> ------------------------------------------
>
>                 Key: YUNIKORN-397
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-397
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: core - common, scheduler-interface, shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>
> The current build does not use the version that is specified in go.mod as the 
> minimal version that we must have for the go tool set.
> The Makefile specifies its own version which might be out of sync (older or 
> newer) than the go.mod version. We should only fail the build if the go tools 
> are older than the version specified in the go.mod file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to