[ 
https://issues.apache.org/jira/browse/YUNIKORN-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193966#comment-17193966
 ] 

Manikandan R commented on YUNIKORN-359:
---------------------------------------

[~wilfreds] Thanks for sharing your thoughts.
{quote}I read through the document and my preference is for format #2.
{quote}
Most of us is aligned with format #2. We can follow the same.  Updated the doc.
{quote}Collection names should be plural shouldn't they? like: _queues_, 
_applications_ and _partitions_
{quote}
Yes. It has been discussed in the doc and community call as well. Updated the 
doc.
{quote}I miss the config endpoint in the definition. I don't think we can do 
without that endpoint. Not sure if we just need to mention that.
{quote}
Yes, We will need to take care of this and all other api's as well. While 
creating sub tasks, will cover this.
{quote}The proposal has {{GET}}, {{DELETE}}, {{PATCH or PUT}} and {{POST}} 
defined for most objects. I do think we should start by defining and 
implementing just the {{GET}} functionality. If and when we decide that we need 
to add that functionality we can do that separately. Adding them in this design 
will give the wrong impression that they will or could come.
{quote}
Yes, Scope of the Jira is to cover only GET functionality. We had talked about 
other operations in the doc for "completeness" purpose and to set this doc as 
base (as general guidelines) for any REST API development going forward.

[~wilfreds] [~wwei] [~sunilg] I think doc has taken a good shape and ready for 
next steps. Shall we go ahead and create a new umbrella Jira and sub tasks (for 
each rest api)?

> Support for "queue" query param filter
> --------------------------------------
>
>                 Key: YUNIKORN-359
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-359
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>            Reporter: Manikandan R
>            Assignee: Manikandan R
>            Priority: Major
>
> Support "queue" query param filter to the following handlers:
>  
> 1. /ws/v1/queues
> Return only queue info whose name exactly matches with "queue" query param
> 2. /ws/v1/nodes
> As of now, Each Node Info has all allocations made on that Node. With this 
> change, it returns only Node info of Nodes whose allocation queue name 
> exactly matches with "queue" query param. In effect, filter happens on 
> allocations.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to