[
https://issues.apache.org/jira/browse/YUNIKORN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199345#comment-17199345
]
Kinga Marton commented on YUNIKORN-335:
---------------------------------------
[~ayubpathan] I added semantic check to the validation. Related the spaces, I
tested it and it is accepted with mixed number of spaces, so I don't think we
should be so strict to error out if there is some extra space, if it is a valid
yaml.
> Invalid config validation and config schema checks for unsupported config
> properties
> ------------------------------------------------------------------------------------
>
> Key: YUNIKORN-335
> URL: https://issues.apache.org/jira/browse/YUNIKORN-335
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Reporter: Ayub Pathan
> Assignee: Kinga Marton
> Priority: Major
> Labels: pull-request-available
>
> * Invalid configuration does not error out - accepts silently but does not
> reload the config.
> 4 spaces & 2 spaces - we should error out if 2 spaces is the standard.
> partitions:
> {noformat}
> -
> name: default
> placementrules:
> - name: tag
> value: namespace
> create: true
> queues:
> - name: root
> submitacl: '*'
> properties:
> application.sort.policy: stateaware{noformat}
> * Any unsupported configuration should not be allowed in the policy map -
> some kind of schema check is needed.
> {noformat}
> partitions:
> -
> name: default
> placementrules:
> - name: tag
> value: namespace
> create: true
> queues:
> - name: root
> submitacl: '*'
> sample: value1
> properties:
> application.sort.policy: stateaware
> sample: value2{noformat}
>
> *Impact: User thinks the config is loaded and consumed by Yunikorn but its
> acutally not. So its important to error out incase any formatting issues.*
> [~wilfreds]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
