[
https://issues.apache.org/jira/browse/YUNIKORN-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang updated YUNIKORN-509:
---------------------------------
Description:
This is a follow up to the review comment:
https://github.com/apache/incubator-yunikorn-k8shim/pull/219#discussion_r557336617.
We can simplify the script by splitting a yaml file for the content encoded in
the script itself. See more in the review comment from [~kmarton].
Also Kinga mentioned we need to add a timeout for:
{code}
until grep 'Running' <(kubectl get pod gangweb -o=jsonpath='{.status.phase}');
do
sleep 1
done
{code}
was:This is a follow up to the review comment:
https://github.com/apache/incubator-yunikorn-k8shim/pull/219#discussion_r557336617.
We can simplify the script by splitting a yaml file for the content encoded in
the script itself. See more in the review comment from [~kmarton].
> Simplify the gangDeploy.sh
> --------------------------
>
> Key: YUNIKORN-509
> URL: https://issues.apache.org/jira/browse/YUNIKORN-509
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: shim - kubernetes
> Reporter: Weiwei Yang
> Assignee: Ting Yao,Huang
> Priority: Minor
>
> This is a follow up to the review comment:
> https://github.com/apache/incubator-yunikorn-k8shim/pull/219#discussion_r557336617.
> We can simplify the script by splitting a yaml file for the content encoded
> in the script itself. See more in the review comment from [~kmarton].
> Also Kinga mentioned we need to add a timeout for:
> {code}
> until grep 'Running' <(kubectl get pod gangweb
> -o=jsonpath='{.status.phase}'); do
> sleep 1
> done
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
