[
https://issues.apache.org/jira/browse/YUNIKORN-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277925#comment-17277925
]
Kinga Marton commented on YUNIKORN-510:
---------------------------------------
Thank you [~Huang Ting Yao] for addressing this! I merged your changes both to
branch-0.10 and master
> Remove the sleep in placeholder manager stop function
> -----------------------------------------------------
>
> Key: YUNIKORN-510
> URL: https://issues.apache.org/jira/browse/YUNIKORN-510
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: shim - kubernetes
> Reporter: Weiwei Yang
> Assignee: Ting Yao,Huang
> Priority: Minor
> Labels: pull-request-available
>
> There is a 3s sleep in the stop function of placeholder manager, per Tingyao:
> "When we send the struct{}{} to stopChan, the Start() might not set Running
> to false immediately. Or we can move sleep to
> TestPlaceholderManagerStartStop(), which is located in
> placeholder_manager_test.go."
> We should remove this from the stop function and move this to the UT code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
