[
https://issues.apache.org/jira/browse/YUNIKORN-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290874#comment-17290874
]
Wilfred Spiegelenburg commented on YUNIKORN-547:
------------------------------------------------
Please check: if the extra changes are minimal (a couple of lines) we can do
this as one change as part of YUNIKORN-460. However if we are touching lot of
code and or areas that we did not touch for the base change it is better to
leave it. We can temporarily duplicate the TerminationType into the message
that we need it in (AllocationAskRelease).
We then have one change to clean both up
> Move TerminationType out of the AllocationRelease message
> ---------------------------------------------------------
>
> Key: YUNIKORN-547
> URL: https://issues.apache.org/jira/browse/YUNIKORN-547
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - scheduler, scheduler-interface, shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Kinga Marton
> Priority: Major
>
> This is a small change in the SI which has a larger impact. The
> TerminationType can be reused for different actions. It is currently embedded
> in the AllocationRelease message.
> We should move it out of the message and make it a separate enumeration that
> can be used if we for instance terminate an asks or application.
> The flow on effect is in the core and shim as both use the value of this
> enumeration to decide if it needs to process the message. That means:
> # update SI
> # update the core dependency and code
> # update the shim dependencies and code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
