[
https://issues.apache.org/jira/browse/YUNIKORN-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17305685#comment-17305685
]
Chaoran Yu commented on YUNIKORN-580:
-------------------------------------
My opinion is that it's okay to slightly over-reserve (i.e. each placeholder
pod can request a bit more resources than the corresponding real pod). Maybe we
can do a percentage-based enforcement: only allow placeholder pod to use x%
more resources than the real pod and set the default value of x to be something
like 10.
Regarding the issue about cleanup, we can do an initial round of cleanup as
soon as the real pods take over the placeholder pods. During this round, the
difference between real pods and placeholders are returned to the queue and
node. When the real pods are done, we only clean up the real pods and don't
have to think about placeholders any more.
Just my two cents.
> Check if the placeholders and real resources are the same
> ---------------------------------------------------------
>
> Key: YUNIKORN-580
> URL: https://issues.apache.org/jira/browse/YUNIKORN-580
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Reporter: Kinga Marton
> Priority: Critical
>
> The design doc stated that the placeholder resources and the real resource
> ask should be the same. However we are not checking it, so it is possible to
> ask for more or less resources, what might cause some unexpected issues.
> Also the resource cleanup is not working properly in this case.
> For example if we have higher resources set for the placeholders than for the
> real pods, after the cleanup the resource difference still be there in the
> queue and node.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
