[ 
https://issues.apache.org/jira/browse/YUNIKORN-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318430#comment-17318430
 ] 

Manikandan R commented on YUNIKORN-490:
---------------------------------------

{quote}

When that is done and we have the files committed we need to open two follow 
PRs:

shim:
 move the shim dependency to the new SI version
 Update all imports that use the core at this moment to point to the SI 
interface
 core:
 move the core dependency to the new SI
 remove the pkg/api/interface.go from the core.
 update all imports to point to the SI interface

{quote}

Created YUNIKORN-636 and YUNIKORN-637 for shim and core side changes 
respectively.



> generate the SchedulerAPI and callback interface from the SI
> ------------------------------------------------------------
>
>                 Key: YUNIKORN-490
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-490
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: scheduler-interface
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Manikandan R
>            Priority: Major
>              Labels: pull-request-available
>
> The SchedulerAPI and callback are closely linked to the SI. The interface is 
> however not defined in the scheduler interface but in the core.
> Currently the core and shim both use that one interface defined in the core 
> to build. This means that a shim must pull in the core to be able to build. 
> It would be preferable to define the interface with the messages in the SI 
> for implementation by both the core and the shims.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to