[
https://issues.apache.org/jira/browse/YUNIKORN-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397908#comment-17397908
]
Wilfred Spiegelenburg commented on YUNIKORN-592:
------------------------------------------------
Sorry that I did not see this any earlier.
To confirm what is needed: I think they belong in a test file. Check where they
are used.
Some belong in the context recovery tests. Not in util at all. At that point
you also need to check if they really need to be exported or not. Some might
belong to other tests.
These utilities for test setup should be kept close to where they are used, not
part of the production code.
> Move test code out of utils.go
> ------------------------------
>
> Key: YUNIKORN-592
> URL: https://issues.apache.org/jira/browse/YUNIKORN-592
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Amit Sharma
> Priority: Major
> Labels: newbie
> Fix For: 1.0.0
>
>
> The utils.go file is a mixture of test and production code. The test code
> does not belong in the utils file and needs to be factored out into a test
> file:
> * K8sResource with NewK8sResourceList
> * PodForTest
> * NodeForTest
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
