[
https://issues.apache.org/jira/browse/YUNIKORN-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398461#comment-17398461
]
Wilfred Spiegelenburg commented on YUNIKORN-792:
------------------------------------------------
We need to finish the template work first as it touches the same area of code.
When that is done we need to look at this. Thank you for logging this. It might
be more work than first anticipated.
We probably also want to go one step further:
* make a split between queue and application sorting at this time
* rename SortPolicy to ApplicationSorter (policy is implied) and give queue its
own
* use an interface like implementation as we do for the node sorting.
* make Undefined the first value in the iota (default remains the Undefined
value)
* update the way we process the policy and remove the need to call it from the
partition for the root queue
* remove logging of unknown properties completely
Keeping Undefined as it will allow a next step, after this refactor, to specify
a partition wide default in the config which we do not have as it is hard coded
to Fair. The move of Undefined to the first entry also opens up an easier
extension of types (like priority which has been talked about for a long time).
> Refactor sorting_policy.go
> --------------------------
>
> Key: YUNIKORN-792
> URL: https://issues.apache.org/jira/browse/YUNIKORN-792
> Project: Apache YuniKorn
> Issue Type: Task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Minor
> Labels: pull-request-available
>
> there are two major changes.
> 1. remove policies.Undefined
> 2. move the code of logging unknown properties into separate function
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
