[ 
https://issues.apache.org/jira/browse/YUNIKORN-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Weiwei Yang updated YUNIKORN-831:
---------------------------------
    Priority: Blocker  (was: Major)

> node sorting should check other resources of nodes instead of comparing node 
> id directly
> ----------------------------------------------------------------------------------------
>
>                 Key: YUNIKORN-831
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-831
>             Project: Apache YuniKorn
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Blocker
>              Labels: pull-request-available
>
> from comment: 
> https://issues.apache.org/jira/browse/YUNIKORN-807?focusedCommentId=17407164&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17407164
>  
> It seems to me a small behavior change is introduced by this patch. This 
> patch scores node according to `resources.LargestUsageShare`. However, the 
> largest usage in our cluster is always storage (and all nodes have same 
> storage capacity). It results in the order is always based on `node id`. 
> Before this patch, the order will compare remaining "usage" (vcore, memory, 
> etc) when largest usage is equal.
> There are two possible solutions.
>  # the nodeScore of nodeRef should keep all usages ([]float64) and the 
> implementation of `Less` function should reuse `resources.CompareShares`
>  # add an new config to enable users to control scope. for example, the 
> following config means we should compare vcore instead of largest resource 
> {code:java}
> nodesortpolicy:
>   type: binpacking
>   usage: vcore{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to