[
https://issues.apache.org/jira/browse/YUNIKORN-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442049#comment-17442049
]
Wilfred Spiegelenburg commented on YUNIKORN-638:
------------------------------------------------
Allowing the image to be made configurable in the taskGroup is not correct. It
can be abused or used as an attack on the cluster. Any image could then be
specified and run by the user as part of an application. That could be an image
that hogs the cpu, is slow to shutdown impacting placeholder swapping or worse.
Using it to pre-load the Spark image is also a problem as we do not have
control over the entry point of the image. The pod might fail to start
correctly if not all configuration is provided. That could also happen for any
custom pod that is specified. We would need to clearly document and specify
that the pod used as a placeholder does not get any special configuration etc.
It needs to be as lightweight as possible, i.e. a pause image, and only defined
at a cluster level.
BTW: we would also need this if the cluster is air gapped and can only use a
specific docker repository.
> Make placeholder image configurable
> -----------------------------------
>
> Key: YUNIKORN-638
> URL: https://issues.apache.org/jira/browse/YUNIKORN-638
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: shim - kubernetes
> Reporter: Chaoran Yu
> Assignee: Amit Sharma
> Priority: Minor
>
> The placeholder image is currently hard-coded as a constant at
> https://github.com/apache/incubator-yunikorn-k8shim/blob/v0.10.0/pkg/common/constants/constants.go#L55.
> In many sectors and enterprises, it's common to have restricted internet
> access. When replacing the placeholder image with something else, the entire
> k8shim image also needs to be rebuilt. It's more inconvenient when different
> deployment environments (dev/test, staging and prod) can't access images in
> another environment.
> It would be better if the placeholder image can be configured in the Helm
> chart:
> https://github.com/apache/incubator-yunikorn-release/blob/master/helm-charts/yunikorn/values.yaml.
> That would make CI/CD easier too
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
