[
https://issues.apache.org/jira/browse/YUNIKORN-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456222#comment-17456222
]
Weiwei Yang commented on YUNIKORN-462:
--------------------------------------
{quote}
if allocate (B) already updates nodes and pods in the shim etc we do not need
to notify the shim anymore. If the notify makes some minor changes after that
fact then we should roll the notify changes into the action for B and be done
with it.
{quote}
I think we are referring to this part of the code.
[This|https://github.com/apache/incubator-yunikorn-core/blob/7ccbebf8230df86c7c7809cbf03c5ad158e1bf0d/pkg/scheduler/context.go#L805-L817]
is the code for the "AssumePod" call [1] and
[this|https://github.com/apache/incubator-yunikorn-core/blob/7ccbebf8230df86c7c7809cbf03c5ad158e1bf0d/pkg/scheduler/context.go#L820-L823]
is the code for "notify the shim" [2]. The reason to have 2 separate calls is
that [1] is a sync'd call and [2] is async. [1] does the necessary updates in
the shim (using a K8s internal API) which is fast, [2] is using our SI
interface to notify the allocations, which is async and the actual pod bindings
may happen seconds later. Are you suggesting combining them into one call? Do
you want to elaborate more details?
> Streamline core to shim update on allocation change
> ---------------------------------------------------
>
> Key: YUNIKORN-462
> URL: https://issues.apache.org/jira/browse/YUNIKORN-462
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - scheduler, shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Manikandan R
> Priority: Major
>
> Currently in the scheduler we have two updates that get send to the shim when
> an allocation is added or released:
> * event to shim RM event handler to allocate
> * reconciler plugin to update the shim caches
> Before YUNIKORN-317 one update was made in the cace the other in the
> scheduler. Now they are both in the scheduler in quick succession. The cache
> update in the shim is needed to make sure that the predicates are seeing the
> correct info. The event does the real bind etc of the allocation on the node.
> We should be able to fold the two calls into one call. However this requires
> changes on both sides and might even impact the SI as it will likely become a
> synced event call.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
