[ 
https://issues.apache.org/jira/browse/YUNIKORN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463523#comment-17463523
 ] 

Weiwei Yang commented on YUNIKORN-956:
--------------------------------------

hi [~wilfreds], [~cchung100m]

Before merging PRs for these issues, I need some clarifications.
I remember we had a long discussion in Jun this year about this. Currently, our 
web UI is depending on these APIs. 
https://issues.apache.org/jira/browse/YUNIKORN-955 is not an easy task to be 
done. Please refer to [~akhilpb]'s comment below:

{quote}
For the changes in the YK web based on the redesigned APIs, I have came up with 
following approaches

*Queues Page:*

Approach-1:
Keep existing /ws/v1/queues (deprecated) API which fetches all queues across 
all partitions. No changes in the current 

Approach-2:
Use the new /ws/v1/partition/{partitionName}/queues API which fetches all 
queues for a particular partitionName. Add a partition dropdown filter in the 
Queues page(we already have one right now, but it's not APi based filter and it 
is an UI based filter) and fetch/show queues based on the partition selected. 
But the YK scheduler needs to define a constant value for the default 
partition. Otherwise UI will have to display queues from the first item of the 
partition list.

*Applications Page*:

Approach-1:
Keep existing /ws/v1/apps (deprecated) API which fetches all applications 
across all partitions and queues. No changes in the current Applications UI 
page.

Approach-2:
Use the new /ws/v1/partition/{partitioName}/queue/{queueName}/applications API 
to fetch all applications for given partitionName and queueName. Will need to 
add partitions and queues filter dropdowns in the Applications UI page. Also 
assuming that, we can get all the applications for the root queueName for a 
given partitionName.

*Nodes Page*:

Approach-1:
Keep existing /ws/v1/nodes (deprecated) API which fetches all the nodes across 
all partitions. No changes in the current Nodes UI page.

Approach-2:
Use new /ws/v1/partition/{partitionName}/nodes API to fetch all the nodes for a 
given partitioName. This will need changes in the UI to add a partition 
dropdown filter in the Nodes page. The UI will show nodes for the default 
partition or for the first item of the partition list.
{quote}

We went through this before and the conclusion was to retain all these APIs 
until we figured out a way to address all necessary changes. Is there anything 
changed now? How do we solve the UI issues?

+ [~akhilpb]

> remove old REST handlers: objects and code
> ------------------------------------------
>
>                 Key: YUNIKORN-956
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-956
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>            Reporter: Wilfred Spiegelenburg
>            Priority: Major
>              Labels: pull-request-available
>
> The new RESt api calls use different paths and objects.
> As part of 1.0 we need to remove the old paths and support one version only.
>  * /ws/v1/apps
>  * /ws/v1/queues
>  * /ws/v1/nodes



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to