[ 
https://issues.apache.org/jira/browse/YUNIKORN-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491795#comment-17491795
 ] 

Weiwei Yang commented on YUNIKORN-979:
--------------------------------------

hi [~lowc1012]

Thanks for working on this. I think we can start by covering a few basic things:
# submit a pod without setting schedulerName, and verify the schedulerName gets 
automatically updated to yunikorn. (we do not need to verify all generated 
labels/annotations, we need to get them covered by UT, if not, add them to UT)
# verify the blacklist of namespaces, make sure YK skips updating pod 
labels/annotations/schedulerName for pods in such namespaces.
# post anj invalid yunikorn-configs config-map updates and make sure it gets 
denied by the admission-controller. 

> Add e2e test coverage for the admission controller
> --------------------------------------------------
>
>                 Key: YUNIKORN-979
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-979
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: test - e2e
>            Reporter: Weiwei Yang
>            Assignee: Ryan Lo
>            Priority: Major
>              Labels: pull-request-available
>
> We need to add coverage for the admission controller, in order to prevent the 
> regressions 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to