[ 
https://issues.apache.org/jira/browse/YUNIKORN-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517162#comment-17517162
 ] 

Craig Condit edited comment on YUNIKORN-1162 at 4/5/22 12:03 AM:
-----------------------------------------------------------------

We need to remove the "fix" in YUNIKORN-1159 and ensure that 
CreateUpdateRequestForNode() accounts for occupied resources again. Thanks 
[~wilfreds] for the help in diagnosing this.


was (Author: ccondit):
We need to remove the "fix" in YUNIKORN-1159 and ensure that 
CreateUpdateRequestForNode() accounts for occupied resources again.

> Recovery code does not update occupied resources on node
> --------------------------------------------------------
>
>                 Key: YUNIKORN-1162
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1162
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Craig Condit
>            Assignee: Craig Condit
>            Priority: Blocker
>
> In YUNIKORN-1159 we discovered and fixed an issue with occupied resources for 
> existing pods not getting processed properly. This was fixed by adding 
> handling for pod additions in the node coordinator. However, it has been 
> pointed out that this code: 
> [https://github.com/apache/yunikorn-k8shim/blob/76ddb316bd099fc783a698d3a8fb3d5543cdaf21/pkg/cache/context_recovery.go#L96...L128]
>  should account for the occupied resources during recovery. We need to 
> determine why that is no longer the case.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to