[
https://issues.apache.org/jira/browse/YUNIKORN-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-601.
--------------------------------------------
Fix Version/s: 1.0.0
Resolution: Fixed
New client can return an error if initialised to fail. All test use the basic
non failing client. New tests can and should be added to leverage the new
failure mode and increase test coverage in the shim
> KubeClient mock does not allow failure tests
> --------------------------------------------
>
> Key: YUNIKORN-601
> URL: https://issues.apache.org/jira/browse/YUNIKORN-601
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes, test - unit
> Reporter: Wilfred Spiegelenburg
> Assignee: ted
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0
>
>
> The way the {{NewKubeClientMock()}} works is to setup functions fo all
> actions that always succeed. That prevents any error handling to be tested in
> the unit tests that require failure for a delete, update or add.
> We should be able to test failure paths also when using the mock.
> The fact that we cannot test failure paths with the mock allowed YUNIKORN-600
> to go undetected.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
