[
https://issues.apache.org/jira/browse/YUNIKORN-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig Condit resolved YUNIKORN-1298.
------------------------------------
Fix Version/s: 1.2.0
Resolution: Fixed
Merged to master.
> fail PR build when generated code files are changed
> ---------------------------------------------------
>
> Key: YUNIKORN-1298
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1298
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: build, scheduler-interface
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> The md file is the source of truth for the constants and proto definition.
> The build generates the files and the resulting build result, including the
> md file as the source of truth are committed as part of a PR.
> The current build does not check that the two files are in sync. This can
> cause issues when a next change gets added or someone build everything from
> scratch. We need to make sure that the build fails if the generated files are
> not in sync with the source data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
