[ 
https://issues.apache.org/jira/browse/YUNIKORN-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628022#comment-17628022
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1373:
-------------------------------------------------

Using a relative path means that every documentation version that is localised 
must create an entry to link the "local" image directory back to the generic 
image directory. That is what is currently done. There is a link from 
/{{{}i18n/zh-cn/docusaurus-plugin-content-pages/img{}}} back to {{/static/img}} 
to make the relative path work.

That would not be needed if you use absolute paths for the images. However I 
agree full paths could break in other ways.

Images should not change between localised versioned and for the overall 
landing page. Shouldn't we use the build in option to add the base url:
{code:java}
import useBaseUrl from '@docusaurus/useBaseUrl';

<img src={useBaseUrl('/img/resource-scheduling.png')} />;{code}
 

> Adopting relative paths
> -----------------------
>
>                 Key: YUNIKORN-1373
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1373
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: website
>            Reporter: Chen Yu Teng
>            Assignee: Chen Yu Teng
>            Priority: Minor
>              Labels: pull-request-available
>
> Images in src/pages/index.js adopts absolute paths.
> Adopting relative path could avoid the url error problem when creating a new 
> translation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to