[ 
https://issues.apache.org/jira/browse/YUNIKORN-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eli Schiff updated YUNIKORN-1476:
---------------------------------
    Description: 
The nodes with negative resources health check has a typo where it correctly 
checks if any nodes have negative resources, but the value it prints in the log 
message is wrong. It instead prints partitions with negative resources. It 
looks like a simple copy paste typo.

 

For example:

In the health check logs I was seeing 
{code:java}
{"Name":"Negative resources","Succeeded":false,"Description":"Check for 
negative resources in the nodes","DiagnosisMessage":"Nodes with negative 
resources: []"}{code}
If this log is saying there are nodes with negative resources, I would expect 
the array at the end to not be empty.

 

I have a fix for this here [https://github.com/apache/yunikorn-core/pull/482]

  was:
The nodes with negative resources health check has a typo where it correctly 
checks if any nodes have negative resources, but the value it prints in the log 
message is wrong. It instead prints partitions with negative resources. It 
looks like a simple copy paste typo.

 

For example:

In the health check logs I was seeing `{{{}{"Name":"Negative 
resources","Succeeded":false,"Description":"Check for negative resources in the 
nodes","DiagnosisMessage":"Nodes with negative resources: []"}`{}}}

If this log is saying there are nodes with negative resources, I would expect 
the array at the end to not be empty.

 

I have a fix for this here https://github.com/apache/yunikorn-core/pull/482


> The nodes with negative resources health check prints partitions instead of 
> nodes
> ---------------------------------------------------------------------------------
>
>                 Key: YUNIKORN-1476
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1476
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>    Affects Versions: 1.1.0
>            Reporter: Eli Schiff
>            Priority: Minor
>              Labels: pull-request-available
>
> The nodes with negative resources health check has a typo where it correctly 
> checks if any nodes have negative resources, but the value it prints in the 
> log message is wrong. It instead prints partitions with negative resources. 
> It looks like a simple copy paste typo.
>  
> For example:
> In the health check logs I was seeing 
> {code:java}
> {"Name":"Negative resources","Succeeded":false,"Description":"Check for 
> negative resources in the nodes","DiagnosisMessage":"Nodes with negative 
> resources: []"}{code}
> If this log is saying there are nodes with negative resources, I would expect 
> the array at the end to not be empty.
>  
> I have a fix for this here [https://github.com/apache/yunikorn-core/pull/482]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to