[
https://issues.apache.org/jira/browse/YUNIKORN-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650506#comment-17650506
]
Wilfred Spiegelenburg commented on YUNIKORN-1089:
-------------------------------------------------
Further issue: {{metadata.getAppMetadata()}} checks the annotation and if it
fails to pass the test still adds the annotation as a tag onto the application.
This will result in the broken annotation to be passed onto the placeholder
creation.
The annotation also seems to be stored multiple times on the application object:
* unwrapped in app.taskGroups as a slice of TaskGroup objects
* wrapped as the annotation via the tags in the taskGroupsDefinition
* wrapped as the annotation in the metadata as part of the Tags.
We need to de-dupe all this and look at storing things once.
> Application handling with invalid task group annotations
> --------------------------------------------------------
>
> Key: YUNIKORN-1089
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1089
> Project: Apache YuniKorn
> Issue Type: New Feature
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Rainie Li
> Priority: Major
>
> In YUNIKORN-1076 we added writing an event to the pod if the task group
> annotation parsing for a gang request failed. We currently accept the
> application and schedule it as if it does not have a gang request defined.
> This might not be what the end user expects.
> The Jira also mentioned failing or rejecting the application if the parsing
> failed. This is a major change:
> * the shim currently does never reject an application
> * is a broken annotation enough reason to reject the application
> Moved out the reject or more invasive handling out of the original Jira so we
> can look at it in more detail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
