[
https://issues.apache.org/jira/browse/YUNIKORN-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654212#comment-17654212
]
Wilfred Spiegelenburg commented on YUNIKORN-1526:
-------------------------------------------------
The field is optional and will not be set in any pod, unless the cluster has
been setup with it, even if you run 1.24 or later.
It is not a user managed field it is set by an admission controller. You cannot
set the field on a pod when you create the pod. The field has been part of the
offical pod spec since 1.16, and marked as a beta field since 1.18. It was only
moved to GA in 1.24.
We need to handle it as an optional field. Even for a release that has the
feature as GA the field can be a nil
> support K8s pod overhead
> ------------------------
>
> Key: YUNIKORN-1526
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1526
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Qi Zhu
> Priority: Major
>
> With K8s 1.24 a pod can now provide an overhead in the pod spec:
> {{{}pod.Spec.Overhead{}}}. The pod overhead allows specifying an overhead
> based on the runtime set on the pod. For certain runtimes this overhead can
> be large. See this [KEP for
> details|https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/688-pod-overhead].
> The scheduler should take into account this overhead if set on a pod. We
> currently calculate the size of the pod based on the containers but do not
> take the overhead into account. That needs to change.
> We need to take the overhead into account as part of scheduling and quota
> calculations: include the {{pod.Spec.Overhead}} resources in the size of the
> pod before sending it to the core. Overhead only support cpu and memory and
> is added to the requests. The plugin framework (node related checks)
> calculates the pod size *each* time it is called (overhead!) and includes the
> overhead. The callback for the predicates must take that into account and not
> be broken by that implementation.
> Adding clearly how we have calculated the overall pod size in the logging is
> a requirement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
