[
https://issues.apache.org/jira/browse/YUNIKORN-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681488#comment-17681488
]
Yongjun Zhang commented on YUNIKORN-1540:
-----------------------------------------
HI [~ccondit], thanks for your work here.
Would you please advise, if we'd like to add a yunikorn configuration
"instance-type-node-label-key" with default value
"node.kubernetes.io/instance-type",
What's the best way to do it?
I was thinking about adding it to the following line
https://github.com/apache/yunikorn-release/blob/master/helm-charts/yunikorn/values.yaml#L108
but why it's empty as "yunikornDefaults: {}"? do we assume all defaults to be
defined within the code, not in this yaml file?
Thanks.
> Fix default placeholder image in documentation
> ----------------------------------------------
>
> Key: YUNIKORN-1540
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1540
> Project: Apache YuniKorn
> Issue Type: Task
> Components: documentation, release, website
> Reporter: Craig Condit
> Assignee: Craig Condit
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> In our helm charts as well as service config, the default pause image for
> placeholders is declared as "registry.gcr.io/pause:3.7". This should be
> "registry.k8s.io/pause:3.7". The code uses the correct value, only the
> documentation is incorrect.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
