[
https://issues.apache.org/jira/browse/YUNIKORN-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686111#comment-17686111
]
Yongjun Zhang edited comment on YUNIKORN-1549 at 2/8/23 9:09 PM:
-----------------------------------------------------------------
Thanks [~zhuqi] for working on this ticket. I agree with the comment above from
[~ccondit].
One question to Qi, with the change you did at YUNIKORN-1389, if a node has
label
node.kubernetes.io/instance-type=xyz
, should we expect the attributes map in the Node struct at the core side
contain this label as
attributes["node.kubernetes.io/instance-type"] = "xyz"
?
For some reason, I did not see this entry at the core side.
{code}
type Node struct {
// Fields for fast access These fields are considered read only.
// Values should only be set when creating a new node and never changed.
NodeID string
Hostname string
Rackname string
Partition string
// Private fields need protection
attributes map[string]string
{code}
Thanks.
was (Author: yzhangal):
Thanks [~zhuqi] for working on this ticket. I agree with the comment above from
[~ccondit].
One question to Qi, with the change you did at YUNIKORN-1389, if a node has
label
node.kubernetes.io/instance-type=xyz
, should we expect the attributes map in the Node struct at the core side
contain this label as
attributes["node.kubernetes.io/instance-type"] = "xyz"
?
For some reason, I did not see this at the core side.
{code}
type Node struct {
// Fields for fast access These fields are considered read only.
// Values should only be set when creating a new node and never changed.
NodeID string
Hostname string
Rackname string
Partition string
// Private fields need protection
attributes map[string]string
{code}
Thanks.
> Introduce a config to specify what attribute to use as instance type
> --------------------------------------------------------------------
>
> Key: YUNIKORN-1549
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1549
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - common
> Reporter: Yongjun Zhang
> Assignee: Qi Zhu
> Priority: Major
> Labels: config, pull-request-available
>
> To make it flexible, we can introduce a yunikorn config
> instance-type-node-label-key: <node-label-key>
> And default the value to k8s’ default
> "node.kubernetes.io/instance-type",
> so by default we take instance type from the following attribute:
> “node.kubernetes.io/instance-type=<instance-type>”
> and users can redefine this based on their own environment.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
