[
https://issues.apache.org/jira/browse/YUNIKORN-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704043#comment-17704043
]
Qi Zhu edited comment on YUNIKORN-1560 at 3/23/23 12:43 PM:
------------------------------------------------------------
Hi [~wilfreds] , first step i submitted a PR to add item in the node for
rackName in scheduler-interface.
[https://github.com/apache/yunikorn-scheduler-interface/pull/88]
And then i will adjust the shim side change and core side changes, thanks!
was (Author: zhuqi):
Hi [~wilfreds] , first step i submitted a PR to add item in the node for
rackName in scheduler-interface.
[https://github.com/apache/yunikorn-scheduler-interface/pull/88]
And then i will ajust the shim side change and core side changes, thanks!
> Remove nodename and rackname from node attributes
> -------------------------------------------------
>
> Key: YUNIKORN-1560
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1560
> Project: Apache YuniKorn
> Issue Type: Sub-task
> Components: core - common, shim - kubernetes, webapp
> Reporter: Wilfred Spiegelenburg
> Assignee: Qi Zhu
> Priority: Major
> Labels: pull-request-available
>
> We have a list of attributes that we pass on from the shim to the core.
> The node name is set in those attributes with the same value as the NodeID.
> We thus send the same value twice. On the core side we treat them as two
> different values but they are not. Needs to be fixed.
> The rackname is set to "default" as the shim does not have the concept of a
> rack name. On the core side we pull that out as a "special" value. We should
> just treat it as another attribute on the node at best. Advanced placement
> checks are done by the shim as they could differ for each shim
> The removal of the rack would also free up UI space to allow sorting or
> grouping nodes on a different attribute in the future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
