[ 
https://issues.apache.org/jira/browse/YUNIKORN-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704409#comment-17704409
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1653:
-------------------------------------------------

See 
[https://github.com/apache/yunikorn-k8shim/pull/557#pullrequestreview-1353328305]
 for more detail.

> use iota instead of defined values for tri-state
> ------------------------------------------------
>
>                 Key: YUNIKORN-1653
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1653
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Priority: Major
>              Labels: newbie
>
> In the admission controller we have a tri-state that uses an integer as the 
> underlying values. We should move to a iota that represents the same three 
> values for clarity:
> {code:java}
> type triState int
> const (
>    UNSET triState = iota - 1
>    FALSE
>    TRUE
> ) {code}
> Replace all the coded values with the triState values, store the triState and 
> return it from function calls.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to