[
https://issues.apache.org/jira/browse/YUNIKORN-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709602#comment-17709602
]
yichiu commented on YUNIKORN-1655:
----------------------------------
Should we reuse DomainYuniKorn in scheduler-interface?
But if we want to add a separator constant, it might not be compatible with
DomainYuniKorn, since DomainYuniKorn contains the separator.
> factor out the domain from annotations, use constant
> ----------------------------------------------------
>
> Key: YUNIKORN-1655
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1655
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: yichiu
> Priority: Minor
> Labels: newbie
>
> {{common/constants/constants.go}} contains al annotations and label
> definitions.
> Each definition specifies its own domaini part instead of re-using a single
> defined constant for {{yunikorn.apache.org}} this could easily lead to typos
> etc in the definitions.
> We should also use a fixed constant for the separator "/" used in all these
> annotations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
